day_of_week #26094
day_of_week #26094
Conversation
|
Hello @Violet-XiaoWeiHuang! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
As mentioned #25924 (comment), |
Codecov Report
@@ Coverage Diff @@
## master #26094 +/- ##
==========================================
- Coverage 91.95% 91.94% -0.01%
==========================================
Files 175 175
Lines 52443 52445 +2
==========================================
- Hits 48224 48222 -2
- Misses 4219 4223 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26094 +/- ##
==========================================
- Coverage 91.95% 91.94% -0.01%
==========================================
Files 175 175
Lines 52443 52445 +2
==========================================
- Hits 48224 48222 -2
- Misses 4219 4223 +4
Continue to review full report at Codecov.
|
| self.ts.dayofweek | ||
| self.ts.day_of_week | ||
|
|
||
| def time_day_of_week(self, tz, freq): |
| @@ -44,7 +44,10 @@ def time_tz(self, tz, freq): | |||
| self.ts.tz | |||
|
|
|||
| def time_dayofweek(self, tz, freq): | |||
There was a problem hiding this comment.
you can remove the original one
| @@ -527,7 +527,8 @@ generated/pandas.DatetimeIndex.ceil,../reference/api/pandas.DatetimeIndex.ceil | |||
| generated/pandas.DatetimeIndex.date,../reference/api/pandas.DatetimeIndex.date | |||
| generated/pandas.DatetimeIndex.day,../reference/api/pandas.DatetimeIndex.day | |||
| generated/pandas.DatetimeIndex.day_name,../reference/api/pandas.DatetimeIndex.day_name | |||
| generated/pandas.DatetimeIndex.dayofweek,../reference/api/pandas.DatetimeIndex.dayofweek | |||
| generated/pandas.DatetimeIndex.dayofweek,../reference/api/pandas.DatetimeIndex.day_of_week | |||
| generated/pandas.DatetimeIndex.day_of_week,../reference/api/pandas.DatetimeIndex.day_of_week | |||
There was a problem hiding this comment.
i don't think you need to add the new one, we don't have original pages for it
| @@ -60,6 +60,7 @@ Properties | |||
| Timestamp.asm8 | |||
| Timestamp.day | |||
| Timestamp.dayofweek | |||
There was a problem hiding this comment.
you can remove the original from the docs
| @@ -138,7 +138,7 @@ Bug Fixes | |||
| - Bug where ``Panel.from_dict`` does not set dtype when specified (:issue:`10058`) | |||
| - Bug in ``Index.union`` raises ``AttributeError`` when passing array-likes. (:issue:`10149`) | |||
| - Bug in ``Timestamp``'s' ``microsecond``, ``quarter``, ``dayofyear``, ``week`` and ``daysinmonth`` properties return ``np.int`` type, not built-in ``int``. (:issue:`10050`) | |||
| - Bug in ``NaT`` raises ``AttributeError`` when accessing to ``daysinmonth``, ``dayofweek`` properties. (:issue:`10096`) | |||
| - Bug in ``NaT`` raises ``AttributeError`` when accessing to ``daysinmonth``, ``dayofweek``, ``day_of_week`` properties. (:issue:`10096`) | |||
There was a problem hiding this comment.
don't change the original what's new notes
| """ | ||
| base, mult = get_freq_code(self.freq) | ||
| return pweekday(self.ordinal, base) | ||
|
|
||
| @property | ||
| def dayofweek(self): |
There was a problem hiding this comment.
just do
dayofweek = day_of_week
|
can you merge master and update per comments |
|
closing as stale. this is pretty close, so ping if you'd like to continue. |
git diff upstream/master -u -- "*.py" | flake8 --diff